Segmentation thumbnail #3507
Merged
Segmentation thumbnail #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fm3 Can you review the back-end part? |
fm3
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
Backend LGTM. What I don’t understand yet is how the backend selects whether to colorize the data or not. Can we be sure that no “color” (raw data) layer will accidentally be idToRGB’d instead of displayed as is? could you briefly explain that @youri-k ?
…interpreted as id #3507
|
You are right @fm3. We couldn't infer this information just from the bytesPerElement and therefore I added a |
added 2 commits
December 20, 2018 11:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
- [ ] Updated migration guide if applicable- [ ] Updated documentation if applicable